work: add and tidy some comments. #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/work/ConditionalWork.h
Outdated
| // first 0 or more times it's called, then if ever returns true, always return | ||
| // true thereafter. It will be called repeatedly until it returns true, but | ||
| // never again (it will actually be deleted once it returns true once). No more | ||
| // detailed reset/retry protocol exists in the relationship between |
There was a problem hiding this comment.
I don't understand what this last sentence means.. do you mean that conditional work doesn't retry?
There was a problem hiding this comment.
No, I mean that the ConditionalWork doesn't propagate any of its lifecycle transitions into the ConditionFn. I'll rephrase.
graydon
force-pushed
the
comments-on-work-subsystem
branch
from
f60cc5b
to
51df1d9
Compare
|
@marta-lokhova updated with rewording |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just added a little commentary on recent Work changes. Let me know if I misunderstood!
Checklist
clang-formatv5.0.0 (viamake formator the Visual Studio extension)