Fuzzing docs and makefile update #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/fuzzing.md
Outdated
| the former is incompatible, and the latter doesn't interoperate with the | ||
| compiler wrappers. | ||
| Start with a clean workspace, `make clean` or cleaner; enable a few compilation flags **WHICH SHOULD | ||
| NEVER BE ENABLED IN PRODUCTION**: `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` and `AFL_LLVM_MODE`; and |
There was a problem hiding this comment.
are you sure about this? FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION seems to be set automatically by afl.
As for AFL_LLVM_MODE, if it's not automatically set, we should just set it when configuring with --enable-afl in the configure script
There was a problem hiding this comment.
Cool, thanks for pointing this out. Did not realize FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION was set, but see it here.
Will add set AFL_LLVM_MODE as part of the configure script.
|
Removed part about setting AFL related env vars as, mentioned above, those are set by either afl or as part of |
|
r+ 385bd0e |
latobarita
added a commit
that referenced
this pull request
Aug 27, 2019
Fuzzing docs and makefile update Reviewed-by: MonsieurNicolas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #2182 , this updates the fuzzing.md doc with what I have learned and the updates I have made. This also updates the shell script so that we generate a lot of inputs and then minimize them with
afl-cmin.