Fix computation of overlay parameters #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplify logic that derives overlay limits
|
r+ a32f920 |
latobarita
added a commit
that referenced
this pull request
Aug 23, 2019
Fix computation of overlay parameters Reviewed-by: marta-lokhova
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way we compute overlay's parameters (how many connections are allowed in/out and how many can be pending):
the old behavior was overly aggressive in trying to enforce the default of 500 pending connections.
Instead, I modified the behavior to bias towards enforcing how many established connections the instance has and only reduce those numbers if limits are causing those targets to not be met