Remove expired upgrades #2272
Remove expired upgrades #2272
Conversation
src/herder/test/UpgradesTests.cpp
Outdated
| @@ -1831,3 +1831,58 @@ TEST_CASE("upgrade invalid during ledger close", "[upgrades]") | |||
| REQUIRE_THROWS(executeUpgrade(*app, makeTxCountUpgrade(0))); | |||
| REQUIRE_THROWS(executeUpgrade(*app, makeBaseReserveUpgrade(0))); | |||
| } | |||
|
|
|||
| void | |||
There was a problem hiding this comment.
static or use empty namespace for helper function
src/herder/test/UpgradesTests.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TEST_CASE("remove expired upgrades", "[upgrades]") |
There was a problem hiding this comment.
We prefer to use sections in this case: not because the setup is expensive but to avoid creating too many ultra small tests (when we run parallel tests, we split using test cases).
Note that using a section also allows (if you want) to move the helper function inside the test case (as a lambda), as to scope it better.
|
looks good. squash and rebase and we'll merge when we open master for 12.1.0 |
sisuresh
force-pushed
the
issue-1661-removeStaleUpgrades
branch
from
590603d
to
d5c6d12
Compare
sisuresh
force-pushed
the
issue-1661-removeStaleUpgrades
branch
from
d5c6d12
to
b1ff396
Compare
|
@sisuresh : |
|
r+ b1ff396 |
Remove expired upgrades Reviewed-by: MonsieurNicolas
Description
Resolves #1661
This change removes pending upgrades if the current ledger close time has gone past the upgrade time by 12 hours.
Checklist
clang-formatv5.0.0 (viamake formator the Visual Studio extension)