Bug 2267 quorum intersection max scc topological order #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamsi
reviewed
Sep 18, 2019
| mTSC.calculateSCCs(); | ||
| mMaxSCC.clear(); | ||
| for (auto const& scc : mTSC.mSCCs) | ||
| { | ||
| if (scc.count() > mMaxSCC.count()) | ||
| if (mMaxSCC.empty() || reach.canReach(mMaxSCC, scc)) |
There was a problem hiding this comment.
Quick note: doesn't Tarjan give you the SCCs in the right (topological) order? So you could simply set maxSCC to the last component found (or actually first, I do not remember the order) instead of iterating here and computing the reachability?
6 tasks
|
This is overcomplex -- see #2279 for simpler fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2267: (partially) order SCCs topologically / by reachability, take a maximally-reachable element in the partial order.
Checklist
clang-formatv5.0.0 (viamake formator the Visual Studio extension)