Bug 2255 hanging test bucketmanager reattach has from publish queue #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est or log locks held.
|
r+ 5250680 |
latobarita
added a commit
that referenced
this pull request
Sep 19, 2019
…ager-reattach-HAS-from-publish-queue Bug 2255 hanging test bucketmanager reattach has from publish queue Reviewed-by: MonsieurNicolas
graydon
deleted the
bug-2255-hanging-test-bucketmanager-reattach-HAS-from-publish-queue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2255
There were 3 separate causes of potential deadlocks, it's a wonder this thing ever completed successfully. Currently able to run in a loop for a couple hours without evident races or deadlocks, so I'll say "I got the last one" (for now).
Checklist
clang-formatv5.0.0 (viamake formator the Visual Studio extension)