Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test HAS in publishqueue #2294

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Test HAS in publishqueue #2294

merged 2 commits into from
Oct 2, 2019

Conversation

marta-lokhova
Copy link
Contributor

No description provided.

@MonsieurNicolas MonsieurNicolas added this to In progress in v12.1.0 via automation Sep 30, 2019
graydon
graydon approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to future returning visitor: the second change here (don't clear if already clear) isn't semantically related to the change, it's just an optimization to avoid doing a pointless IO to sniff the protocol version when we don't need to.

@MonsieurNicolas
Copy link
Contributor

@latobarita: retry

@marta-lokhova
Copy link
Contributor Author

Travis looks stuck

@MonsieurNicolas
Copy link
Contributor

@latobarita: retry

@MonsieurNicolas
Copy link
Contributor

r+ 915eae2

latobarita added a commit that referenced this pull request Oct 2, 2019
@latobarita
Merge pull request #2294 from marta-lokhova/test_HAS_in_publishqueue
f263aa3 
Test HAS in publishqueue

Reviewed-by: MonsieurNicolas
@latobarita latobarita merged commit 915eae2 into stellar:master Oct 2, 2019
v12.1.0 automation moved this from In progress to Done Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graydon graydon graydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v12.1.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marta-lokhova @MonsieurNicolas @graydon @latobarita