Windows build fixes #2352
Merged
Windows build fixes #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjove
reviewed
Nov 20, 2019
| @@ -2397,7 +2397,8 @@ LedgerTxnRoot::Impl::getBestOffer(Asset const& buying, Asset const& selling, | |||
| prefetch(toPrefetch); | |||
|
|
|||
| cached->allLoaded = | |||
| std::distance(newOfferIter, offers.cend()) < BATCH_SIZE; | |||
| static_cast<size_t>(std::distance(newOfferIter, offers.cend())) < | |||
There was a problem hiding this comment.
Exactly the same thing appears on line 2310. Is there no warning there?
There was a problem hiding this comment.
interestingly it wasn't... regardless, I fixed the other call site to be consistent
MonsieurNicolas
force-pushed
the
windowsBuild20191120
branch
from
fa9b824
to
abcfe2c
Compare
|
@jonjove updated |
|
r+ abcfe2c |
latobarita
added a commit
that referenced
this pull request
Nov 20, 2019
Windows build fixes Reviewed-by: jonjove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.