Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix force broadcast in herder #2650

Merged
merged 2 commits into from Aug 4, 2020
Merged

Fix force broadcast in herder #2650

merged 2 commits into from Aug 4, 2020

Commits on Aug 3, 2020

  1. overlay: force rebroadcast actually rebroadcasts 

    it was preserving mPeersTold so "force" never worked...
    @MonsieurNicolas
    MonsieurNicolas committed Aug 3, 2020
    Copy the full SHA
    7e775dd View commit details
    Browse the repository at this point in the history

  2. herder: don't reject messages as aggressively during bootstrap 

    In test cases we have situations where we bootstrap a new network,
and lose sync within the first few ledgers (before MAX_SLOTS_TO_REMEMBER=12 ledgers).
When this happens, we want to ensure that we continue to process SCP messages,
regardless of their timestamp.

The old code was approximating "never been in sync" by just looking at the ledger
window, which is inacurate.
    @MonsieurNicolas
    MonsieurNicolas committed Aug 3, 2020
    5
    Copy the full SHA
    4526d39 View commit details
    Browse the repository at this point in the history