properly implement Windows version of sign-transaction #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokopt
approved these changes
Aug 21, 2020
There was a problem hiding this comment.
I know nothing about MFC, but having looked at the API docs online, I think the buffer length parameters all look correct, as do the parameter usages as I understand from https://docs.microsoft.com/en-us/windows/win32/api/wincred/ns-wincred-credui_infoa and https://docs.microsoft.com/en-us/windows/win32/api/wincred/nf-wincred-creduipromptforcredentialsa and https://docs.microsoft.com/en-us/previous-versions/windows/desktop/legacy/aa366877(v=vs.85), so this looks good to me.
|
Thanks @rokopt |
|
r+ 56fe1af |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses proper dialog when asking for the private key (instead of console based workarounds that don't work great on Windows)