Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate operation meta if an operation has already failed #2865

Merged
merged 1 commit into from Jan 11, 2021

Conversation

jonjove
Copy link
Contributor

@jonjove jonjove commented Jan 7, 2021

Description

This is a slight optimization to the way we currently generate meta. I think the new version is also easier to understand. This originally caught my attention because I was wondering why we were generating meta differently prior to protocol version 14.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v5.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@MonsieurNicolas MonsieurNicolas added this to In progress in v15.2.0 via automation Jan 11, 2021
@MonsieurNicolas
Copy link
Contributor

r+ 0b34c8c

@latobarita latobarita merged commit 44f8d27 into stellar:master Jan 11, 2021
v15.2.0 automation moved this from In progress to Done Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants