Add an option to disable console logging #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the behavior I proposed in the issue is the more sensible one: This explains why sysadmins get confused with the existing behavior (including our own ops team). I agree that for core developers logging to console is probably what people want even when logging to files, but that is niche enough as a use case that opt-in into this is probably the better option. |
marta-lokhova
force-pushed
the
logging_updates
branch
from
3b4efd6
to
caf8842
Compare
|
okay, I updated the PR @MonsieurNicolas |
|
r+ caf8842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3386
Note that instead of disabling console logging by default, I added an option to disable it. I find console logging useful most of the time when developing/testing, as it's easier to quickly eyeball the logs instead of having to deal with files. But if anyone feels strongly about this, let me know. Otherwise, I think people who do not want logs in both places simply need to update their run command to include the new flag (I think it's also better this way in case some of the operators rely on default console logging)