Fixes to verify-checkpoints command #3505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
verify-checkpoints
was broken since https://github.com/stellar/stellar-core/pull/3229/files#diff-1fe071ca6fa86c1b4830199b49f2cd39e811459529da0682484f4c0fbc8486bfL891. This change adds the buffering logic back, along with a new test (Note that the test focuses on the waiting condition only; the writing logic itself is already tested elsewhere)