Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install-rust.sh #3527

Merged
merged 5 commits into from
Sep 16, 2022
Merged

Add install-rust.sh #3527

merged 5 commits into from
Sep 16, 2022

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Sep 14, 2022

Add a script for installing rust using rustup, with a fixed expected SHA256 for the rustup binary.

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but looks greater otherwise.

install-rust.sh Outdated Show resolved Hide resolved
@@ -0,0 +1,48 @@
#!/bin/sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more tweaks missing from what I see: both docker/Dockerfile.testing and .devcontainer/Dockerfile need to be adjusted (and probably need to use this script). Also README.md has wrong instructions (should point to use install-rust.sh instead)

@graydon
Copy link
Contributor Author

graydon commented Sep 15, 2022

@MonsieurNicolas fixed issues described (also tweaked the Dockerfile.testing to enable protocol-next)

@MonsieurNicolas
Copy link
Contributor

r+ 489ca94

@latobarita latobarita merged commit 6d61a82 into stellar:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants