-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install-rust.sh #3527
Add install-rust.sh #3527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, but looks greater otherwise.
af3841e
to
b3e7637
Compare
@@ -0,0 +1,48 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more tweaks missing from what I see: both docker/Dockerfile.testing and .devcontainer/Dockerfile need to be adjusted (and probably need to use this script). Also README.md has wrong instructions (should point to use install-rust.sh instead)
3dcb648
to
489ca94
Compare
@MonsieurNicolas fixed issues described (also tweaked the Dockerfile.testing to enable protocol-next) |
r+ 489ca94 |
Add a script for installing rust using rustup, with a fixed expected SHA256 for the rustup binary.