Drop old peers post v20 upgrade #4120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-lokhova
force-pushed
the
drop_old_peers_post_upgrade
branch
3 times, most recently
from
5cf2048
to
7dcdc3f
Compare
marta-lokhova
commented
Jan 5, 2024
| @@ -212,7 +213,7 @@ class Peer : public std::enable_shared_from_this<Peer>, | |||
|
|
|||
| std::string mRemoteVersion; | |||
| uint32_t mRemoteOverlayMinVersion; | |||
| uint32_t mRemoteOverlayVersion; | |||
| std::optional<uint32_t> mRemoteOverlayVersion; | |||
There was a problem hiding this comment.
Made this optional instead of 0, so that we don't drop pending peers when we don't know their version yet (this can happen if we've sent HELLO, but haven't received a response)
marta-lokhova
force-pushed
the
drop_old_peers_post_upgrade
branch
from
7dcdc3f
to
9addd76
Compare
MonsieurNicolas
requested changes
Jan 5, 2024
src/overlay/OverlayManagerImpl.cpp
Outdated
| { | ||
| maybeDrop<decltype(OverlayManagerImpl::PeersList::mPending)>( | ||
| mPending, predicate, version, reason); | ||
| maybeDrop<decltype(OverlayManagerImpl::PeersList::mAuthenticated)>( |
There was a problem hiding this comment.
you don't need to do all this templating stuff: you can just call getPendingPeers and getRandomAuthenticatedPeers (that also gives you a list), if you don't want to randomize for the later, you can refactor it.
marta-lokhova
force-pushed
the
drop_old_peers_post_upgrade
branch
from
9addd76
to
de714e6
Compare
|
r+ de714e6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.