Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BucketListDB Cleanup #4124

Merged
merged 1 commit into from
Jan 11, 2024
Merged

BucketListDB Cleanup #4124

merged 1 commit into from
Jan 11, 2024

Conversation

SirTyson
Copy link
Contributor

@SirTyson SirTyson commented Jan 6, 2024

Description

Improves BucketListDB metrics and improves bloom filter configuration.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@SirTyson SirTyson self-assigned this Jan 10, 2024
marta-lokhova
marta-lokhova requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@marta-lokhova marta-lokhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few minor suggestions

src/bucket/BucketManagerImpl.cpp Outdated Show resolved Hide resolved
src/bucket/BucketIndexImpl.cpp Outdated Show resolved Hide resolved
@marta-lokhova
Copy link
Contributor

r+ 94a92de

@latobarita latobarita merged commit 38b446e into stellar:master Jan 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marta-lokhova marta-lokhova marta-lokhova requested changes

@sisuresh sisuresh Awaiting requested review from sisuresh

Assignees

@SirTyson SirTyson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SirTyson @marta-lokhova @latobarita