Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin rust version to exact version 1.74.1 #4131

Merged

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Jan 10, 2024

Description

What

Pin the rust version using for building to exact the version 1.74.1.

Why

It appears that the stable releases of stellar-core have been built with Rust version 1.74.1.

According to @graydon in stellar/rs-soroban-env#1311 (comment) the intent is to pin stellar-core to a version of Rust.

At the moment it is pinned to a minor version of Rust, but new patch releases of Rust will cause rebuilds of stellar-core, or new builds of new commits, to automatically use the newer patch releases.

I think it's likely we'd want to use newer releases, but we should remain in control of when they are adopted and ideally builds of past source using the rust-toolchain.toml file to select a version are as consistent and reproducible as possible. i.e. They should use the same version of Rust they were originally built with. e.g. 1.74.1, not 1.74.n.

This change doesn't prevent us from changing the version on new Rust releases. It just makes sure we're the ones making the decision on when the change occurs.

Close stellar/rs-soroban-env#1311

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@graydon
Copy link
Contributor

graydon commented Jan 11, 2024

r+ d1617dc

@latobarita latobarita merged commit 3892245 into stellar:master Jan 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating rust-version going forward
3 participants