Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed resource limit bug in SOROBAN_UPLOAD #4134

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fixed resource limit bug in SOROBAN_UPLOAD #4134

merged 1 commit into from
Jan 11, 2024

Conversation

SirTyson
Copy link
Contributor

Description

Resolves #4110

Fixes resource limit bug in SOROBAN_UPLOAD loadgen mode.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

marta-lokhova
marta-lokhova approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@marta-lokhova marta-lokhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marta-lokhova
Copy link
Contributor

r+ 408d42a

@latobarita latobarita merged commit 816acc3 into stellar:master Jan 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marta-lokhova marta-lokhova marta-lokhova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loadgen doesn't set resource bounds correctly
3 participants
@SirTyson @marta-lokhova @latobarita