Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new config settings #4142

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Add new config settings #4142

merged 3 commits into from
Jan 22, 2024

Conversation

sisuresh
Copy link
Contributor

Description

Resolves #4126

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh requested a review from dmkozh January 17, 2024 18:10
# These events will be put into a list in the non-hashed portion of the
# meta, and this list will contain all events so ordering can be
# maintained between all events. The default value is false, and this
# should not be enabled on validators.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 'should not' -> 'can not' - the validator node will crash if this is enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@dmkozh
Copy link
Contributor

dmkozh commented Jan 22, 2024

r+ f8cad56

@latobarita latobarita merged commit 7a089ce into stellar:master Jan 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the example config with Soroban flags
3 participants