Increase eviction scan size to 1 mb #4146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anupsdf
reviewed
Jan 18, 2024
soroban-settings/phase1.json
Outdated
| @@ -301,7 +301,7 @@ | |||
| "temp_rent_rate_denominator": 5356800, | |||
| "max_entries_to_archive": 100, | |||
| "bucket_list_size_window_sample_size": 30, | |||
| "eviction_scan_size": 100000, | |||
| "eviction_scan_size": 1000000, | |||
There was a problem hiding this comment.
Should we set it to 1024 * 1024 here?
There was a problem hiding this comment.
I'm not sure that this would work, I think we can only use constants here and not expressions because it's a JSON file.
There was a problem hiding this comment.
I'm not sure that this would work, I think we can only use constants here and not expressions because it's a JSON file.
I meant the result of the multiplication, 1048576, for keeping it accurately at 1 MB.
SirTyson
force-pushed
the
scan-size-increase
branch
from
847ee22
to
e95032f
Compare
|
r+ e95032f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increases phase 1 eviction scan size to 1 mb.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)