Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set upper bound on scan size in the upgrade utils #4155

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Set upper bound on scan size in the upgrade utils #4155

merged 1 commit into from
Jan 24, 2024

Conversation

sisuresh
Copy link
Contributor

Description

Set upper bound on scan size in the upgrade utils as a safety check.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

SirTyson
SirTyson approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@SirTyson SirTyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sisuresh sisuresh requested a review from dmkozh January 23, 2024 19:55
@dmkozh
Copy link
Contributor

dmkozh commented Jan 23, 2024

r+ 96967e3

@latobarita latobarita merged commit 395bc28 into stellar:master Jan 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirTyson SirTyson SirTyson approved these changes

@dmkozh dmkozh dmkozh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sisuresh @dmkozh @latobarita @SirTyson