Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve survey documentation #4160

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

marta-lokhova
Copy link
Contributor

No description provided.

Copy link
Contributor

@bboston7 bboston7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more detail to the docs! I just had a clarifying question and found a small typo.

scripts/README.md Show resolved Hide resolved
* `messagesRead`: The total number of messages read from this peer.
* `messagesWritten`: The total number of messages written to this peer.
* `nodeId`: Node's public key.
* `secondsConnected`: The total number of seconds this node has been connected.
Copy link
Contributor

@bboston7 bboston7 Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the number seconds the peer has been connected to this node specifically, or is it the number of seconds the peer has been connected to the network (the peer's uptime)? I imagine it's the first, but it's ambiguous from the wording.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! It is the former. I've updated the wording to clarify this.

@graydon
Copy link
Contributor

graydon commented Jan 29, 2024

r+ ff170a1

@latobarita latobarita merged commit 1248bd0 into stellar:master Jan 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants