Adds poolshare index for BucketsDB #4224
Conversation
src/bucket/BucketIndex.h
Outdated
| @@ -37,6 +37,9 @@ class BucketManager; | |||
| // BucketIndex abstract interface | |||
| class BucketIndex : public NonMovableOrCopyable | |||
| { | |||
| protected: | |||
| static const inline std::vector<PoolID> kEmptyVec = {}; | |||
There was a problem hiding this comment.
This doesn't follow the naming style. Also I don't think it needs to be a class member as it's only used in a single function (so could be defined right there).
| @@ -45,7 +49,7 @@ template <class IndexT> class BucketIndexImpl : public BucketIndex | |||
| void | |||
| load(Archive& ar) | |||
| { | |||
| ar(keysToOffset, filter); | |||
| ar(assetToPoolID, keysToOffset, filter); | |||
There was a problem hiding this comment.
Is there a risk of loading the old version with the new code (or vice versa)?
There was a problem hiding this comment.
No, in BucketIndex::load, we load the version and pageSize first. These two values are always serialized first no matter the index version. Then we check the index version, and if the on-disk version number doesn't match the expected version number, we drop the on-disk index and reindex from scratch.
There was a problem hiding this comment.
should we delete the outdated index right away instead of keeping both until the bucket gets cleaned up? (so that we don't accidentally use it)
There was a problem hiding this comment.
We don't actually have both indexes persisted, but we generate a new index, then rename the new index the the same name as the old index. On linux, this deletes the old file. However, I looked up in the standard and this behavior is implementation defined, so I agree we should delete explicitly here.
SirTyson
force-pushed
the
poolshare-load-fix
branch
from
d79faca
to
6656553
Compare
| @@ -45,7 +49,7 @@ template <class IndexT> class BucketIndexImpl : public BucketIndex | |||
| void | |||
| load(Archive& ar) | |||
| { | |||
| ar(keysToOffset, filter); | |||
| ar(assetToPoolID, keysToOffset, filter); | |||
There was a problem hiding this comment.
should we delete the outdated index right away instead of keeping both until the bucket gets cleaned up? (so that we don't accidentally use it)
SirTyson
force-pushed
the
poolshare-load-fix
branch
from
6656553
to
66c6f1f
Compare
|
r+ 66c6f1f |
Description
Resolves #4223
This extends
BucketIndexto include a map ofAsset -> poolIDin order to optimizeloadPoolShareTrustLinesByAccountAndAsset. This change improves query performance by around ~2500x and minimally impacts memory overhead. I suspect the memory increase is approximately 1.5 MB, but this is so small that I was not able to measure a change during testing.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)