Bump dependencies March 2024 #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonsieurNicolas
changed the title
6 tasks
dmkozh
reviewed
Mar 4, 2024
| @@ -472,6 +472,12 @@ FieldList::getFieldNames() const | |||
| return names; | |||
| } | |||
|
|
|||
| inline std::string | |||
| format_as(const NullField&) | |||
There was a problem hiding this comment.
without this it won't compile with the new version of the fmt library
They fixed a bug in the way fmt::format works, and we're supposed to provide custom formatters for custom types
There was a problem hiding this comment.
Interesting, do we still need the old formatter defined on line 11?
There was a problem hiding this comment.
yes done, didn't see it
|
@SirTyson please r+ this one when you get a chance (I think you took a dependency on it) |
|
r+ 2fbd233 |
r plussing on behalf of Garand since he doesn't have r plus access yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SirTyson was asking me something about sqlite and I realized that we didn't bump it for a while.
This brings core up to date.
Moving to the 3.x Catch2 release seems to be more involved. We may want to do this at some point.