Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the range of the testnet write fees. #4239

Merged
merged 1 commit into from Mar 13, 2024

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Mar 12, 2024

Description

Due to small bucket list size, even relatively minor changes in testnet (+/- 20 MB) cause significant fee shifts and as a result fees that are significantly higher than on pubnet. We can't achieve perfect synchronization between the network, but at least with this change the range is reduce to [0.9, 2] times of the initial phase 2 write fee, which hopefully will be relatively close to the pubnet fee for a while.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh
Copy link
Contributor

r+ f04d03b

latobarita added a commit that referenced this pull request Mar 12, 2024
Reduce the range of the testnet write fees.

Reviewed-by: sisuresh
Due to small bucket list size, even relatively minor changes in testnet (+/- 20 MB) cause significant fee shifts and as a result fees that are significantly higher than on pubnet. We can't achieve perfect synchronization between the network, but at least with this change the range is reduce to [0.9, 2] times of the initial phase 2 write fee, which hopefully will be relatively close to the pubnet fee for a while.
@sisuresh
Copy link
Contributor

r+ 56945e8

@latobarita latobarita merged commit a7bb37b into stellar:master Mar 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants