Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define custom cereal override for ConfigUpgradeSetKey and use it #4247

Merged
merged 2 commits into from Apr 12, 2024

Conversation

sisuresh
Copy link
Contributor

Description

Resolves #4246

The new output now looks like -

[Herder INFO] Armed with network upgrades: upgradetime=2000-07-21T22:04:00Z, {
    "configupgradesetkey": {
        "contractID": "CDEWOG5BY6RL6HPKAO5GUPMZDEW2Y22V3J7PHI3WZN7HASTWGTMI6ITO",
        "contentHash": "7fa751106b2a7988dea3af733ca86484f1581f97c2ec9553bb36d402c612847d"
    }
}

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh requested a review from dmkozh April 11, 2024 22:56
@dmkozh
Copy link
Contributor

dmkozh commented Apr 11, 2024

r+ f3ffbbe

@latobarita latobarita merged commit 2725b15 into stellar:master Apr 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong format used for contract ID when scheduling Soroban network upgrades
3 participants