Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rebuild tables after enabling BucketListDB #4267

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

SirTyson
Copy link
Contributor

@SirTyson SirTyson commented Apr 2, 2024

Description

Resolves #4265

After migrating to BucketListDB, TTL and CONTRACT_CODE tables are rebuilt when they should not be. This PR fixes this.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

Copy link
Contributor

@dmkozh dmkozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should wait a bit until 20.4 release lands before merging this.

Copy link
Contributor

@marta-lokhova marta-lokhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge as soon as master reopens.

@marta-lokhova
Copy link
Contributor

r+ 575e22d

@latobarita latobarita merged commit 64c4845 into stellar:master Apr 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some tables are recreated after BucketListDB migration
4 participants