Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate non-Soroban txs with Soroban ext in checkValid #4296

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Apr 25, 2024

Description

Validate non-Soroban txs with Soroban ext in checkValid. This check is already present in tx queue, so the observed behavior shouldn't change.

Also fixed VS build.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh
Copy link
Contributor

r+ b132488

@latobarita latobarita merged commit 3ab9717 into stellar:master Apr 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants