Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to Test SEP-8 Payments #170

Merged
merged 4 commits into from
May 25, 2021

Conversation

marcelosalloum
Copy link
Contributor

What

Add instructions to Test SEP-8 Payments in the Demo Wallet using our SEP-8 reference server sep8-server.dev.stellar.org.

Closes #160

@marcelosalloum marcelosalloum self-assigned this May 24, 2021
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@marcelosalloum marcelosalloum marked this pull request as ready for review May 24, 2021 18:58
README.md Outdated
1. Click "Generate keypair", and then click "Create account" - this will create a balance of 10,000 XLM.
2. Click “Add asset” and add `MYASSET` with the anchor home domain `sep8-server.dev.stellar.org`.
3. Click “Add trustline” - this will allow you to hold MYASSET.
4. Click in the "Copy" link at the right of your public key and use that value to get some unities of MYASSET using the link `https://sep8-server.dev.stellar.org/friendbot?addr=<paste_your_address_here>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Click in the "Copy" link at the right of your public key and use that value to get some unities of MYASSET using the link `https://sep8-server.dev.stellar.org/friendbot?addr=<paste_your_address_here>`.
4. Click on the "Copy" link on the right of your public key and use that value to get some unities of MYASSET using the link `https://sep8-server.dev.stellar.org/friendbot?addr=<paste_your_address_here>`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the wording in 6bb496a.

README.md Outdated
2. Click “Add asset” and add `MYASSET` with the anchor home domain `sep8-server.dev.stellar.org`.
3. Click “Add trustline” - this will allow you to hold MYASSET.
4. Click in the "Copy" link at the right of your public key and use that value to get some unities of MYASSET using the link `https://sep8-server.dev.stellar.org/friendbot?addr=<paste_your_address_here>`.
5. Select "SEP-8 Send" from the dropdown for MYASSET and click "Start" in the modal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. Select "SEP-8 Send" from the dropdown for MYASSET and click "Start" in the modal.
5. Select "SEP-8 Send" from the dropdown of MYASSET and click "Start" in the modal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the wording in 6bb496a.

README.md Outdated
3. Click “Add trustline” - this will allow you to hold MYASSET.
4. Click in the "Copy" link at the right of your public key and use that value to get some unities of MYASSET using the link `https://sep8-server.dev.stellar.org/friendbot?addr=<paste_your_address_here>`.
5. Select "SEP-8 Send" from the dropdown for MYASSET and click "Start" in the modal.
6. In the "destination" field, input an address that also has a trustline to MYASSET. You can use this destination address for it if you don't have one: `GBID36ML6VVNPIF6SQATQW5QIBREQAVEHQIUMWDLQCSVIYX2IJGK4KPP`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we remember to update this address when the testnet resets?

Copy link
Contributor Author

@marcelosalloum marcelosalloum May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I'll remove the reference to that address so we don't risk the documentation becoming outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the sentence about the existing address in 6bb496a.

@stellar-jenkins
Copy link

@marcelosalloum marcelosalloum merged commit d1824ea into release/1.2.0 May 25, 2021
@marcelosalloum marcelosalloum deleted the feature/sep8-add-testing-intructions branch May 25, 2021 12:42
marcelosalloum added a commit that referenced this pull request Jul 19, 2021
### What

Add instructions to Test SEP-8 Payments in the Demo Wallet using our SEP-8 reference server sep8-server.dev.stellar.org.

Closes #160
marcelosalloum added a commit that referenced this pull request Jul 19, 2021
### What

Add instructions to Test SEP-8 Payments in the Demo Wallet using our SEP-8 reference server sep8-server.dev.stellar.org.

Closes #160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants