Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SEP-8 "action_required" responses with GET action methods #176

Merged

Conversation

marcelosalloum
Copy link
Contributor

@marcelosalloum marcelosalloum commented May 27, 2021

What

Support SEP-8 "action_required" responses with GET action methods.

Why

We were only supporting SEP-8 responses with POST action methods, which is not the default response according with the SEP.

@stellar-jenkins
Copy link

@marcelosalloum marcelosalloum marked this pull request as ready for review May 27, 2021 15:17
@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

@marcelosalloum marcelosalloum merged commit c021051 into release/1.2.0 May 27, 2021
@marcelosalloum marcelosalloum deleted the feature/sep8-support-actionrequired-get-flow branch May 27, 2021 16:00
marcelosalloum added a commit that referenced this pull request Jul 19, 2021
### What

Support SEP-8 "action_required" responses with GET action methods.

### Why

We were only supporting SEP-8 responses with POST action methods, which is not the default response according with the SEP.
marcelosalloum added a commit that referenced this pull request Jul 19, 2021
### What

Support SEP-8 "action_required" responses with GET action methods.

### Why

We were only supporting SEP-8 responses with POST action methods, which is not the default response according with the SEP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants