Add a note about accuracy of close time #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janewang PTAL |
|
Preview is available here: |
|
@marta-lokhova I think we should specify our treatment of leap seconds, wdyt? |
|
Hi @janewang, the reason I left that off is because we specify that it's a UNIX timestamp, which by definition excludes leap seconds (so it's not unique to Stellar). But if you think we should keep the definition of UNIX system time, I can add it back. Lmk! |
|
For whatever it's worth, I was thinking the same as @marta-lokhova when I read the changes. Specifying it's a Unix timestamp "automatically" includes the fact that leap-seconds are excluded from the count. For anyone who doesn't already know that, I don't imagine they would care to know it Hehehe |
|
SGTM |
janewang
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #509