Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor error handling page #649

Merged
merged 61 commits into from
Jul 8, 2024
Merged

Conversation

aditya1702
Copy link
Contributor

@aditya1702 aditya1702 commented Jun 4, 2024

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com>
@stellar-jenkins
Copy link

Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com>
@stellar-jenkins
Copy link

Co-authored-by: Jake Urban <10968980+JakeUrban@users.noreply.github.com>
@stellar-jenkins
Copy link

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I did a quick first pass review

network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
network/horizon/admin-guide/error-handling.mdx Outdated Show resolved Hide resolved
aditya1702 and others added 6 commits June 7, 2024 13:58
Co-authored-by: Molly Karcher <mdarkar@gmail.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
aditya1702 and others added 3 commits July 3, 2024 16:40
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
@stellar-jenkins
Copy link

aditya1702 and others added 4 commits July 3, 2024 16:43
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

6 similar comments
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

aditya1702 and others added 2 commits July 8, 2024 12:14
Co-authored-by: George <Shaptic@users.noreply.github.com>
# Conflicts:
#	docs/build/guides/basics/create-account.mdx
#	docs/build/guides/basics/send-and-receive-payments.mdx
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

@stellar-jenkins
Copy link

@aditya1702 aditya1702 requested a review from Shaptic July 8, 2024 20:25
@stellar-jenkins
Copy link

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 great effort on this!!

@stellar-jenkins
Copy link

@aditya1702 aditya1702 merged commit c8ad0db into stellar:main Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants