You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When integrating SEP-7 on Vibrant (built on React Native), we noticed that some libraries (analytics-react-native is one of them) aren't too happy with SEP-7 uri pattern and throw an error (crashes the app) when users try to open the app via a SEP-7 deeplink because they are expecting the deeplink's uri to be an absolute hierarchical URI instead of SEP-7's opaque URI (uri reference doc). I understand why using opaque URI makes more sense for SEP-7 (no host and etc), but I wanted to bring this up before SEP-7 gets widely adopted.
Android's manifest <data>document mentions using <scheme>://<host>:<port>[<path>|<pathPrefix>|<pathPattern>|<pathAdvancedPattern>|<pathSuffix>] format and on google play's deeplinks section, I see that it automatically adds // after web+stellar:.
We were able to resolve the crash by replacing "web+stellar:" with "web+stellar://" in MainActivity.java.
What would you like to see?
I would like to hear everyone's thoughts on this. There are ways to resolve this. I was surprised by this when libraries caused the app to crash.
What alternatives are there?
Don't use the dependencies that expect a hierarchical uri (android.intent.uri)
Update the uri scheme in MainActivity.java (what we did)
The text was updated successfully, but these errors were encountered:
What problem does your feature solve?
When integrating
SEP-7
on Vibrant (built on React Native), we noticed that some libraries (analytics-react-native is one of them) aren't too happy withSEP-7 uri
pattern and throw an error (crashes the app) when users try to open the app via aSEP-7
deeplink because they are expecting the deeplink's uri to be an absolutehierarchical URI
instead ofSEP-7
'sopaque URI
(uri reference doc). I understand why using opaque URI makes more sense forSEP-7
(nohost
and etc), but I wanted to bring this up beforeSEP-7
gets widely adopted.Android's manifest
<data>
document mentions using<scheme>://<host>:<port>[<path>|<pathPrefix>|<pathPattern>|<pathAdvancedPattern>|<pathSuffix>]
format and on google play's deeplinks section, I see that it automatically adds//
afterweb+stellar:
.We were able to resolve the crash by replacing
"web+stellar:"
with"web+stellar://"
inMainActivity.java
.What would you like to see?
I would like to hear everyone's thoughts on this. There are ways to resolve this. I was surprised by this when libraries caused the app to crash.
What alternatives are there?
android.intent.uri
)MainActivity.java
(what we did)The text was updated successfully, but these errors were encountered: