Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-7: thoughts on using "web+stellar://" instead of "web+stellar:"? #1366

Closed
jeesunikim opened this issue Jun 27, 2023 · 1 comment
Closed
Labels

Comments

@jeesunikim
Copy link

jeesunikim commented Jun 27, 2023

What problem does your feature solve?

When integrating SEP-7 on Vibrant (built on React Native), we noticed that some libraries (analytics-react-native is one of them) aren't too happy with SEP-7 uri pattern and throw an error (crashes the app) when users try to open the app via a SEP-7 deeplink because they are expecting the deeplink's uri to be an absolute hierarchical URI instead of SEP-7's opaque URI (uri reference doc). I understand why using opaque URI makes more sense for SEP-7 (no host and etc), but I wanted to bring this up before SEP-7 gets widely adopted.

Android's manifest <data> document mentions using <scheme>://<host>:<port>[<path>|<pathPrefix>|<pathPattern>|<pathAdvancedPattern>|<pathSuffix>] format and on google play's deeplinks section, I see that it automatically adds // after web+stellar:.

custom-schemes

We were able to resolve the crash by replacing "web+stellar:" with "web+stellar://" in MainActivity.java.

What would you like to see?

I would like to hear everyone's thoughts on this. There are ways to resolve this. I was surprised by this when libraries caused the app to crash.

What alternatives are there?

  1. Don't use the dependencies that expect a hierarchical uri (android.intent.uri)
  2. Update the uri scheme in MainActivity.java (what we did)
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants
@jeesunikim and others