Rust: Add serde json support #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,8 @@ | |||
| use core::{array::TryFromSliceError, fmt, fmt::Debug, ops::Deref}; | |||
|
|
|||
| #[cfg(feature = "serde")] | |||
| use serde::{Deserialize, Serialize}; | |||
There was a problem hiding this comment.
I'd be inclined to remove the use and fully qualify the serde types at their call sites. I don't think it will be too burdensome, and I think it will aid readability since the type names are rather generic and the crate name will help provide context at their use.
lib/xdrgen/generators/rust.rb
Outdated
| @@ -134,6 +134,7 @@ def render_source_comment(out, defn) | |||
|
|
|||
| def render_struct(out, struct) | |||
| out.puts "#[derive(Clone, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]" | |||
| out.puts "#[cfg_attr(feature = \"serde\", derive(Serialize, Deserialize), serde(rename_all = \"camelCase\"))]" | |||
There was a problem hiding this comment.
It is common in Ruby to use alternative string style when the string will contain double quotes:
Suggested change
| out.puts "#[cfg_attr(feature = \"serde\", derive(Serialize, Deserialize), serde(rename_all = \"camelCase\"))]" | |
| out.puts %{#[cfg_attr(feature = "serde", derive(Serialize, Deserialize), serde(rename_all = "camelCase"))]} |
Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
|
Some other things I'd like to explore, but depending on difficulty we can kick them down the road: |
This was referenced Jul 13, 2022
leighmcculloch
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of #112.
Deserialization of
BoxandVecMis not implemented yet withoutalloc. Should be fixed as part of stellar/rs-stellar-xdr#47.Close #112