Skip to content

Commit

Permalink
Fix (non-sparse) saving and loading of APPNP models (#1682)
Browse files Browse the repository at this point in the history
The `final_layer` access was left over from #1204.

Sparse APPNP models still hit #1251.

See: #1680
  • Loading branch information
huonw committed Jun 17, 2020
1 parent c67b612 commit 20270d5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
1 change: 0 additions & 1 deletion stellargraph/layer/appnp.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ def get_config(self):

config = {
"units": self.units,
"final_layer": self.final_layer,
"teleport_probability": self.teleport_probability,
}

Expand Down
5 changes: 1 addition & 4 deletions tests/layer/test_appnp.py
Original file line number Diff line number Diff line change
Expand Up @@ -293,10 +293,7 @@ def test_APPNP_apply_propagate_model_sparse():

@pytest.mark.parametrize(
"sparse",
[
pytest.param(False, marks=pytest.mark.xfail(reason="FIXME #1680")),
pytest.param(True, marks=pytest.mark.xfail(reason="FIXME #1251")),
],
[False, pytest.param(True, marks=pytest.mark.xfail(reason="FIXME #1251"))],
)
def test_APPNP_save_load(tmpdir, sparse):
G, _ = create_graph_features()
Expand Down

0 comments on commit 20270d5

Please sign in to comment.