stelligent/cfn_nag#416 Explicit encoding when reading files in rspec tests #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 25, 2020 18:40
…r JSON text in CFN templates.
…lidation method and additional errors.
…rse, and removing UTF-8 characters from template key names.
….rb in case of bad syntax.
ghost
approved these changes
Mar 26, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates stelligent/cfn_nag#416
Description
Fixes GitHub Action workflow failure.
GitHub Action runners seem to use
UTF-8as the default file encoding, which conflicted with an assumption made for two of the rspec tests. This PR explicitly sets the file encoding when reading in the file during those tests.Testing