Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stelligent/cfn_nag#416 Explicit encoding when reading files in rspec tests #76

Merged
6 commits merged into from
Mar 26, 2020
Merged

stelligent/cfn_nag#416 Explicit encoding when reading files in rspec tests #76

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
169a91b
stelligent/cfn_nag#416 Adding 'ArgumentError' handler when parsing fo…
Mar 25, 2020
1b5af68
stelligent/cfn_nag#416 Relocating rescue statement to cover entire va…
Mar 25, 2020
937035a
stelligent/cfn_nag#416 Changing file read encoding to UTF-8 in cfn_pa…
Mar 25, 2020
c7af9df
stelligent/cfn_nag#416 Adding handling of NoMethodError in references…
Mar 26, 2020
75dd490
Merge branch 'master' into feature/encoding-handling
Mar 26, 2020
b787463
Explicitly reading template as US-ASCII encoding for certain rspec te…
Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions spec/validator/cloudformation_validator_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@

it 'raises an error when JSON contains UTF-8 characters' do
invalid_character_json = File.read(
'spec/test_templates/json/template_with_utf8_characters.json'
'spec/test_templates/json/template_with_utf8_characters.json',
encoding: Encoding::US_ASCII
)

expect do
Expand All @@ -72,7 +73,8 @@

it 'raises an error when YAML contains UTF-8 characters' do
invalid_character_template = File.read(
'spec/test_templates/yaml/template_with_utf8_characters.yml'
'spec/test_templates/yaml/template_with_utf8_characters.yml',
encoding: Encoding::US_ASCII
)

expect do
Expand Down