Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to install through homebrew #86

Closed
ghost opened this issue Nov 17, 2017 · 22 comments · Fixed by #267
Closed

Add ability to install through homebrew #86

ghost opened this issue Nov 17, 2017 · 22 comments · Fixed by #267
Labels
customer Initiated from, or received feedback about from outside Stelligent feature

Comments

@ghost
Copy link

ghost commented Nov 17, 2017

No description provided.

@ghost ghost assigned oshaughnessy Nov 17, 2017
@ghost ghost unassigned oshaughnessy Sep 16, 2018
@ghost
Copy link
Author

ghost commented May 8, 2019

https://www.pivotaltracker.com/story/show/164842066

@ghost ghost closed this as completed May 8, 2019
@ghost ghost added the customer Initiated from, or received feedback about from outside Stelligent label May 30, 2019
@ghost ghost reopened this May 30, 2019
@Mr-Lizard
Copy link
Contributor

I'd like to take a stab at this, if you would assign me.

@jesseadams
Copy link

@Mr-Lizard It wont let me assign it to you as you aren't a member of our org. However, feel free to knock it out! We'll check in with you before you start work on it if it comes to that.

@ghost
Copy link
Author

ghost commented Jun 7, 2019

Not sure if it would make life easier or dovetail but... the ruby-packer tool is something I'll mention here:

brew install squashfs
curl -L http://enclose.io/rubyc/rubyc-darwin-x64.gz | gunzip > rubyc
./rubyc --gem=cfn-nag --gem-version 0.3.89 cfn_nag

@Mr-Lizard
Copy link
Contributor

I have the beginnings of a workable formula. However, it would probably be best to create a 'Homebrew_taps' repository to use as a 'tap' per standard homebrew conventions. Also, what email should I use for the point of contact in the formula ?

@jesseadams
Copy link

jesseadams commented Jun 19, 2019 •
edited

@Mr-Lizard Thanks for working on this. You can use "Stelligent cfn-nag Team" and cfn-nag@stelligent.com for a point of contact.

@Mr-Lizard
Copy link
Contributor

Alrighty, this is available for your testing pleasure.

The first time, to add my tap:

brew tap Mr-Lizard/homebrew-tap

Thereafter :

brew install cfn-nag

and even:

brew test cfn-nag

@jesseadams
Copy link

@Mr-Lizard Thanks for this work. I am having issues on my machine locally with these instructions but I am guessing it has something to do with paths and rbenv. I'll take a closer look soon.

@Mr-Lizard
Copy link
Contributor

No problem @jesseadams. If your homebrew install is old, you may want to completely uninstall and reinstall it - mine was quite buggy until I did that.

@Mr-Lizard
Copy link
Contributor

I should note that the formula name is 'cfn-nag', however the executables are still underscored, 'cfn_nag' !

@twellspring
Copy link
Contributor

@jesseadams I just ran the above instructions and the worked correctly.
Mojave 10.14.5
Homebrew 2.1.6

I did the install on both the default OS ruby and 2.6
ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-darwin18]
ruby 2.3.7p456 (2018-03-28 revision 63024) [universal.x86_64-darwin18]

@Mr-Lizard
Copy link
Contributor

Thank you, Mr. Wells !

@Mr-Lizard
Copy link
Contributor

After doing some further research, using a subdirectory of this repo for a homebrew repo doesn't seem to be possible. So...there are 2 options:

  1. Create a repository for Stelligents own homebrew formulae. It should begin with 'homebrew-', usually the convention is 'homebrew-taps'

  2. Go for the throat and submit it (via PR) to homebrew. I would be happy to handle this.

I recommend using both, starting with 1 before going for an official homebrew formula submission. Gentlemen, what is your bidding ?

@oshaughnessy
Copy link
Contributor

Ooh, good insight! We do have https://github.com/stelligent/homebrew-tap set up for this. Looks like we're using it for mu and config-lint already.

@Mr-Lizard
Copy link
Contributor

There should be an icon for embarrassment ! My apologies !

@oshaughnessy
Copy link
Contributor

No, not at all. Glad you brought it up, because I forgot it was there until you mentioned it. Do you have access to submit a PR to that repo instead?

@Mr-Lizard
Copy link
Contributor

Not sure, I would have what any lizard off the street would have.

@oshaughnessy
Copy link
Contributor

Looks like it's public. I think you'd be good to go.

@Mr-Lizard
Copy link
Contributor

Mr-Lizard commented Jul 11, 2019 via email

@Mr-Lizard
Copy link
Contributor

A PR has been submitted to https://github.com/stelligent/homebrew-tap .

@twellspring
Copy link
Contributor

Here is the PR: stelligent/homebrew-tap#1

@twellspring twellspring mentioned this issue Jul 25, 2019
Merged
@twellspring
Copy link
Contributor

PR is merged and the following now works for MacOS and Ubuntu (tested on Bionic)

brew tap stelligent/homebrew-tap
brew install cfn-nag

It is currently on v0.4.33
Working on a process for keeping brew up to date.

twellspring pushed a commit that referenced this issue Jul 25, 2019
@builder-pluralstack
#86 install cfn_nag using brew on Mac and Linux
019f5f6
@twellspring twellspring mentioned this issue Jul 25, 2019
Merged
twellspring pushed a commit that referenced this issue Aug 1, 2019
@builder-pluralstack
#86 Add brew installation instructions to readme
2b99d05
@ghost ghost closed this as completed in #267 Aug 11, 2019
ghost pushed a commit that referenced this issue Aug 11, 2019
#86 install cfn_nag using brew on Mac and Linux (#267)
e8d3ae8 
* #86 install cfn_nag using brew on Mac and Linux

* Add bash to brew install README code

* #86 Add brew installation instructions to readme

* Update deploy_local script to uninstall brew gem
leppikallio pushed a commit to leppikallio/cfn_nag that referenced this issue Aug 28, 2019
stelligent#86 install cfn_nag using brew on Mac and Linux (stelligent…
d3f7aff 
…#267)

* stelligent#86 install cfn_nag using brew on Mac and Linux

* Add bash to brew install README code

* stelligent#86 Add brew installation instructions to readme

* Update deploy_local script to uninstall brew gem
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer Initiated from, or received feedback about from outside Stelligent feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#86 install cfn_nag using brew on Mac and Linux stelligent/cfn_nag
4 participants
@jesseadams @oshaughnessy @twellspring @Mr-Lizard