#86 install cfn_nag using brew on Mac and Linux #267
Conversation
|
Hold on this PR. I totally removed cfn_nag (and all dependencies) and brew from my system and re-installed brew, then tried to install cfn_nag via brew and it did not work. So I need to research what is going on |
|
Are you by any chance using rbenv ? I'm noticing that it doesn't seem to play well with brew. |
|
@Mr-Lizard yes I use rbenv I just created a clean MacOS on Virtualbox and the install worked fine. The issue we have now is setting up automation to update the brew definition every time cfn_nag is updated. An alternative I am ran across and am looking at is https://github.com/sportngin/brew-gem With that the install of cnf_nag would be And then no automation is needed to keep the homebrew-tap definition up to date |
|
Well that would totally undo all my work on the formula in question. But...who cares ? It would work beautifully and be trouble free! |
|
@Mr-Lizard Thanks for your understanding on this. The more I dug in to automation of the updating of the homebrew-tap definition and having to hard code in the exact versions of every dependency, the less I liked the solution. I played with parsing the cfn_nag gemspec file and building the homebrew-tap based on the dependencies listed in the gemspec. But that seems messy and error prone. |
|
Once this is merged, I will PR the removal of the tap definition. |
|
@twellspring , No problem. It is very decent of you to give me credit for this PR, thank you. Have you evaluated the 'brew gem' method anymore ? |
|
@Mr-Lizard Yes, I updated this PR to use the 'brew gem' method. Just waiting for it to be approved. |
ghost
merged commit …#267) * stelligent#86 install cfn_nag using brew on Mac and Linux * Add bash to brew install README code * stelligent#86 Add brew installation instructions to readme * Update deploy_local script to uninstall brew gem
As discussed in stelligent/cfn_nag#267, cfn_nag uses `brew-gem` for handling install via homebrew, and this formula is not used in the cfn_nag documentation.
Closes #86
Update Readme to include brew gem installation method.
@erickascic The brew tap solution would require homebrew-tap/Formula/cfn-nag.rb to be updated any time a dependency of cfn-nag.gemspec gets updated. We could make a script that reads cfn-nag.gemspec and then writes a new homebrew-tap/Formula/cfn-nag.rb but that means having to handle the
~>and seems messy and prone to errors. Thebrew-gemdoes not ensure ruby is installed, but that is easy enough to add to the install instructions:This appears to be the simplest from a maintenance standpoint and it is two commands just like the tap version would be, so the complexity for users is basically the same.