Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#74 Raise violations on administrator access for SAM functions #392

Merged
12 commits merged into from
Mar 2, 2020

Conversation

pshelby
Copy link
Contributor

@pshelby pshelby commented Feb 28, 2020

Closes #74

Description

Upgrading cfn-model version to utilize better Serverless transforms of IAM roles per serverless function. Modified rpsec test to ensure AdministratorAccess and other permissive policies were marked as violations. See stelligent/cfn-model#64 for more information on how this was accomplished.

Testing

  1. All rubocop and rspec tests passed.
  2. See stelligent/cfn_nag#74 Reworking Serverless transform to more closely match how SAM transforms templates cfn-model#64 for before and after output from cfn_nag.

@pshelby pshelby requested a review from a user February 28, 2020 18:32
@ghost ghost merged commit abc0f6a into stelligent:master Mar 2, 2020
@pshelby pshelby deleted the feature/sam-function-admin-access branch March 3, 2020 13:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look for AdministratorAccess policy in SAM function
1 participant