Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RetroAchivements #1677

Merged
merged 4 commits into from Feb 26, 2021
Merged

Implement RetroAchivements #1677

merged 4 commits into from Feb 26, 2021

Conversation

stenzek
Copy link
Owner

@stenzek stenzek commented Feb 23, 2021

Opening as a PR since people want to test it.

Still remaining TODO:

  • Linux support (only has a Windows HTTP downloader for now)
  • Better handling of login errors (don't block the UI)
  • Login UI for big duck mode
  • Handle re-login when token is invalid
  • Implement hardcode mode and restrictions
  • Android UI

What works:

  • Login, unlock list downloads, achievement granting
  • Popups and achievement browser
  • Settings in Qt frontend

NOTE: FULLSCREEN UI MUST BE ENABLED IN GENERAL SETTINGS TO SEE ACHIEVEMENT POPUPS

@andercard0
Copy link
Contributor

andercard0 commented Feb 23, 2021

Feedback and Suggestions:

  • While Open Quick Menu or even in Big Duck Mode does not pause the game (I'd suggest a option as we have "pause on focus loss")

  • For some weird reason when open quick menu (QT) it freezes the game entirely, did choose Resume Game but it seems to be paused. In NoGUI works well.

  • Shortcut exit full-screen is not working in Big Duck Mode
    tried to change / bind another key for "toggle full-screen button" it prompt me to hit other key I choose other key on the keyboard but duck does not bind it at all.

Even, if my shortcut (F11) key is assigned already it does not work.

Tried to edit (settings.ini) removing F11 for full-screen and no deal; i got into shortcut screen, bind shortcut, timer goes 5..4..3..2.. but any key isn't being accepted.

In Big Duck Mode Quick Menu does work pretty well!

  • Would be great if we have Cheevos retroactively. meaning, as soon as my MC is loaded it 'see' my progress there and this way upgrade my Cheevos progress as well.

Really do not know if this is viable but would be a good thing so we would not have to replay our games again :p

  • Source text in English .ts is 'Gane Slot' instead Game Slot.

  • when login fails duckstation does not give me another chance to redo / type my credentials (as you may view below) i have to hit close window and retry.

image

  • Time of stamp or card cheevos ... whatever they are called are a bit long. maybe, 25 seconds on screen would be enough.

  • Cheevos aren't being updated at Retro Achievements site and / or when updates it, information of the current dates aren't accurate i.e down below

This. has been retrieved from a friend today take a look at the date/time: 2021/01/18 totally wrong, he did reset those datas in order to test Duck Cheevos but it is wrong.

image

and here:
My profile's page aren't not updated as well, but, at the right you can see CRASH progressed today normally
image

Really don't know if you can do something about this but sorry if this isn't!

  • Don't know if this is important but as you may view duck is not being showed. Checked resources folder and duck.png is there.

image

  • When in big duck mode while fast forward FF volume is too loud as you can see both are set up at 16 of volume but when i Fast forward the game goes pretty loud. instead of being low

Workaround: if you have a hotkey to increase or decrease volume use it then issue will be 'solved'

image

@stenzek
Copy link
Owner Author

stenzek commented Feb 24, 2021

  • While Open Quick Menu or even in Big Duck Mode does not pause the game (I'd suggest a option as we have "pause on focus loss")

Added "Pause On Menu" option.

  • Would be great if we have Cheevos retroactively. meaning, as soon as my MC is loaded it 'see' my progress there and this way upgrade my Cheevos progress as well.

I suspect not, unless the memory the achievement is looking for happens to have the correct value.

  • Source text in English .ts is 'Gane Slot' instead Game Slot.

Can't see this anywhere?

  • when login fails duckstation does not give me another chance to redo / type my credentials (as you may view below) i have to hit close window and retry.

Fixed.

  • Cheevos aren't being updated at Retro Achievements site and / or when updates it, information of the current dates aren't accurate i.e down below

Fixed.

  • Don't know if this is important but as you may view duck is not being showed. Checked resources folder and duck.png is there.

Might be a bad logo.png replacement. Remove it and see if that changes anything.

  • When in big duck mode while fast forward FF volume is too loud as you can see both are set up at 16 of volume but when i Fast forward the game goes pretty loud. instead of being low

Fixed.

@stenzek stenzek force-pushed the cheevos branch 2 times, most recently from 640c02e to 414dfb7 Compare February 24, 2021 16:20
@andercard0
Copy link
Contributor

andercard0 commented Feb 24, 2021

Feedback 2

Only QT is working NO-GUI still loads then fails; tested in two different machines no deal.
(Tested with master and dev both work good but not the one from this PR)

  • I open quick menu and emulation pauses but yet have to use my mouse to choose resume game to close it property and also have to unpause the emulation via Pause button in toolbar.

Note: this happens only while in Full-screen mode.

If possible ideal scenario would be a hotkey in order to open quick menu as well as to close it. likewise i do with full-screen on and off with F11 for example.

Still in regards quick menu, while I'm checking my achievements screen it remais unpaused even with the new option "Pause ON menu" turned On. as you can see down below (ofc it will not be visible cause is only a screenshot) :p but believe me is not pausing at that screen

  • Other thing I've noticed is as soon as i open quick menu there is no way (as said earlier) to return with controls but, if i use LB or RB the options are highlighted but even so i can't choose any option with my controller only with keyboard arrows which.. is strange because i never set up my keyboard for nothing but up arrow Vol, up and down arrow to Vol, down. When did try it it does both ie. Volume down + move trough list menu options.

  • Add Duckstation into RetroCheevos download Page:
    Suggestion to add DuckStation at this page https://retroachievements.org/download.php so people will know that DuckStation has this feature. - Maybe in the future when all its functions are already implemented and working well. :)

@stenzek stenzek force-pushed the cheevos branch 2 times, most recently from ff13f0f to 4b71cf5 Compare February 25, 2021 15:01
@andercard0
Copy link
Contributor

andercard0 commented Feb 25, 2021

Feedback 3

  • QT - Controllers aren't being used correctly
    Made a video in order to explain this issue better take a look where you can please
    At 00:19 when Resume Game and Exit Game are highlighted it was me pressing L1 / R1
    this is the only input i can do in that screen; While in it game is paused.

When choose Achievements options game is unpased, as already reported earlier, so beyond
00:26 game is running which Cheevos screen and all that but when in Fullscreen it's a bit
annoying at this point, cause my mouse pointer isn't visible.

Video: https://streamable.com/p0w7ly

If you allow me a suggestion (for QT) would be, when quick menu open game keep running but
in a low volume and 'turn off' game input; if you notice when Cheevos screen is opened
if you press any button game is responding to it instead let me navigate trough cheeevos
list. I only can do it via mouse and keyboard arrow up and dow which again, i set up those
for vol increase (UP) and vol decrease (down) both is being accepted.

  • Returning to game from: cheevos, load, save, cheats menus are perfect!

  • Not sure if this is suppose to happen but after click on "Change Disc" > Close (X)
    it return to the game but in a paused state.

Note: you'll not see my mouse pointer at the end but believe me had to click pause button.

Video: https://streamable.com/d2h2zm

  • Crash while opening Cheevos Settings
    To reproduce. Settings > Achievements Settings Emulator hangs and crash.

  • Big Duck Mode (NoGui)

  • Crash while opening Cheevos Settings Same behavior as in QT
    Was testing Settings > Achievements Settings Emulator hangs and crash.

  • DuckStation Minimizes as soon as i click / change focus to another monitor (only while full-screen)

@stenzek
Copy link
Owner Author

stenzek commented Feb 26, 2021

Crash in big duck mode should be fixed. Probably should do some quick re-testing as I had to switch from wininet to winhttp to support POST requests (for rich presence).

@andercard0
Copy link
Contributor

Crash in big duck mode should be fixed. Probably should do some quick re-testing as I had to switch from wininet to winhttp to support POST requests (for rich presence).

Yup! fixed indeed. only the other reported issues still remaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants