Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Add conditional data breakpoints, and a few minor bug fixes #2473

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
8489e1f
Decrement bp counter when removing a bp from the list
mateusfavarin Aug 1, 2021
cb06da7
Fix default bp counter when cleared
mateusfavarin Aug 1, 2021
f98ccfd
Fix bp list UI not updating when clearing all bps
mateusfavarin Aug 1, 2021
d3d1a41
Fix bp ids not updating when a bp is removed
mateusfavarin Aug 1, 2021
12b29dd
Add conditional bp UI
mateusfavarin Aug 2, 2021
5364eab
Fix typo
mateusfavarin Aug 2, 2021
e66b633
UI tweaks, add data structs that will encapsulate the new debugging l…
mateusfavarin Aug 2, 2021
11e06cc
Change address size field to be a line
mateusfavarin Aug 2, 2021
e8d7441
Update data structure for s_breakpoints
mateusfavarin Aug 2, 2021
511e55c
Implement condition breakpoints
mateusfavarin Aug 3, 2021
a83f259
Add default textline values for the DebugPrompt
mateusfavarin Aug 3, 2021
f511bcc
Fix bp not disabling via checkbox
mateusfavarin Aug 3, 2021
411852d
Change instruction format to hex always use Hex for consistency
mateusfavarin Aug 3, 2021
a40286e
Add the possibility to edit current breakpoints
mateusfavarin Aug 3, 2021
1253f69
Breakpoint editor: fix cancel button not working
mateusfavarin Aug 3, 2021
18d93de
Add menu to edit and delete breakpoints
mateusfavarin Aug 3, 2021
5cec416
Conditional data bp: add support for lwl, lwr, swl, swr
mateusfavarin Aug 3, 2021
6e5f938
Fix breakpoint being created in the edit mode
mateusfavarin Aug 4, 2021
e4690b3
Make CPU registers editable
mateusfavarin Aug 5, 2021
c77da8b
Make disasm comments follow the selected addr in the codeView
mateusfavarin Aug 6, 2021
71b5f37
CPU Reg edit: only scroll to PC if PC was changed
mateusfavarin Aug 6, 2021
90b5e4b
Make stack editable
mateusfavarin Aug 6, 2021
8a7efb2
Add string as a search pattern in the memory view
mateusfavarin Aug 7, 2021
157662d
Change LookAhead memread function
mateusfavarin Aug 7, 2021
09bf376
Add a range check in DataBreakpointCheck
mateusfavarin Aug 8, 2021
844ab25
Change bp status bar message
mateusfavarin Aug 9, 2021
a39ddd4
Fix range address tests
mateusfavarin Aug 25, 2021
e74d0ee
Merge branch 'stenzek:master' into debugger
mateusfavarin Aug 25, 2021
5b97601
Merge branch 'stenzek:master' into debugger
mateusfavarin Sep 7, 2021
2228e33
Fix crash when closing the debugger
mateusfavarin Sep 9, 2021
d9334eb
Merge branch 'stenzek:master' into debugger
mateusfavarin Sep 9, 2021
8c46371
Remove unnecessary import
mateusfavarin Sep 9, 2021
1a95f1f
Fix crash when loading a save state with the debugger unpaused
mateusfavarin Sep 9, 2021
45a9c10
Merge branch 'stenzek:master' into debugger
mateusfavarin Sep 10, 2021
e5bd628
Merge branch 'stenzek:master' into debugger
mateusfavarin Sep 25, 2021
752a4f4
Make instructions editable
mateusfavarin Sep 25, 2021
997e290
Add memory size selector in the mem viewer
mateusfavarin Sep 25, 2021
ed83c6f
Always highlight selected address
mateusfavarin Sep 26, 2021
1a78ff2
Add memory display UI
mateusfavarin Sep 26, 2021
9fbea5f
Merge branch 'stenzek:master' into debugger
mateusfavarin Sep 26, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dep/msvc/qt
Submodule qt updated 398 files
6 changes: 6 additions & 0 deletions src/core/cdrom.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,12 @@ u8 CDROM::ReadRegister(u32 offset)

case 2: // always data FIFO
{
if (m_data_fifo.IsEmpty())
{
Log_DevPrint("Data FIFO empty on read");
return 0x00;
}

const u8 value = m_data_fifo.Pop();
UpdateStatusRegister();
Log_DebugPrintf("CDROM read data FIFO -> 0x%08X", ZeroExtend32(value));
Expand Down
Loading