Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanish (Spain) translation update #3007

Merged
merged 1 commit into from Sep 4, 2023
Merged

Spanish (Spain) translation update #3007

merged 1 commit into from Sep 4, 2023

Conversation

IlDucci
Copy link
Contributor

@IlDucci IlDucci commented Sep 4, 2023

  • Adding translations for the new strings (Big Picture, wireframe options, Setup Wizard...). WARNING!!! Big Picture mode was not tested in DuckStation because the strings are still being displayed in English, so I am unable to test them for the time being.
  • Some strings were copied from PCSX2 Spanish (Spain) translation, also worked on by myself.
  • Unification pass for certain terms.
  • Cleanup of unused strings. WARNING! A number of strings in the Settings menu have reverted back to English.

@IlDucci
Spanish (Spain) translation update
ce3f4aa 
- Adding translations for the new strings (Big Picture, wireframe options, Setup Wizard...). WARNING!!! Big Picture mode was not tested in DuckStation because the strings are still being displayed in English, so I am unable to test them for the time being.
 - Some strings were copied from PCSX2 Spanish (Spain) translation, also worked on by myself.
 - Unification pass for certain terms.
 - Cleanup of unused strings. WARNING! A number of strings in the Settings menu have reverted back to English.
@stenzek
Copy link
Owner

stenzek commented Sep 4, 2023 •
edited

WARNING!!! Big Picture mode was not tested in DuckStation because the strings are still being displayed in English, so I am unable to test them for the time being.

Weird, it should be fine, I was only checking Korean before. Maybe the cache isn't being tossed... Nope, seems fine on language change too.

@stenzek stenzek merged commit 2d0d357 into stenzek:master Sep 4, 2023
0 of 6 checks passed
@IlDucci
Copy link
Contributor Author

IlDucci commented Sep 4, 2023

I'm also getting this error whenever switching languages:
imagen

@stenzek
Copy link
Owner

stenzek commented Sep 5, 2023

Can't reproduce that :/

@IlDucci
Copy link
Contributor Author

IlDucci commented Sep 7, 2023

Damn... So far, I just tried to rename the Users/Documents/Duckstation folder to reset the settings, to see if any of those two errors disappear, and they are still there. Is there anything else I could check?

@stenzek
Copy link
Owner

stenzek commented Sep 7, 2023

That assert should definitely never fire if you never started a game and/or big picture mode.

@IlDucci
Copy link
Contributor Author

IlDucci commented Sep 7, 2023

That assert should definitely never fire if you never started a game and/or big picture mode.

Confirmed. Did a new cleaned folder without going there and the language selection shows no issues.

@stenzek
Copy link
Owner

stenzek commented Sep 7, 2023

Could you upload the settings.ini from the profile which had the issue? I'll try to reproduce with that when I have time.

Feel free to remove the paths and any RetroAchievements details, but otherwise there shouldn't be any other identifying information in there.

@IlDucci
Copy link
Contributor Author

IlDucci commented Sep 7, 2023 •
edited

So the assertion failed disapppeared when I deleted the following files from my Users/USER/Documents/Duckstation folder:

  • The DX caches.
  • All the savestates (turns out there was quite a lot, so a lot of old ones were probably involved).
  • All the screenshots.

EDIT: False solution, I mixed things up. I'll upload the Settings.ini right away.

@IlDucci
Copy link
Contributor Author

IlDucci commented Sep 7, 2023

Settings file: settings - copia.zip

@IlDucci IlDucci deleted the es_ES_update_20230903 branch September 22, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@IlDucci @stenzek