Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear secret value when called by user #1598

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Clear secret value when called by user #1598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion remediation/secrets/secrets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,12 +184,13 @@ func GetSecrets(queryStringParams map[string]string, authHeader string, svc dyna

// If record exists, check if secrets are set
if gitHubWorkflowSecretsFromDB != nil {
if !authHeaderVerified && gitHubWorkflowSecretsFromDB.AreSecretsSet {
if !authHeaderVerified { // called by user
for i := range gitHubWorkflowSecretsFromDB.Secrets {
// the secret should be cleared. but if not, it should only be returned to the authorized GitHub Action
gitHubWorkflowSecretsFromDB.Secrets[i].Value = ""
}
}
// called by GitHub Action
return gitHubWorkflowSecretsFromDB, nil
}

Expand Down