Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: --env CLI flag parses value with = in them incorrectly #151

Closed
1 task done
plungingChode opened this issue Oct 4, 2023 · 4 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@plungingChode
Copy link
Contributor

plungingChode commented Oct 4, 2023

What happened?

I tried to pass an environment variable with a value similar to A=B.

stepci --env 'env=A=B`

The variable was parsed as

{ env: "A" }

What did you expect to happen?

It should have been parsed as

{ env: "A=B" }

Version

2.6.8

Environment

Node v16.20.0

How can we reproduce this bug?

Run stepci --env 'env=A=B'

Relevant log output

No response

Would you be interested in working on a bugfix for this issue?

  • Yes! Assign me
@plungingChode plungingChode added the bug Something isn't working label Oct 4, 2023
plungingChode added a commit to plungingChode/stepci that referenced this issue Oct 4, 2023
plungingChode added a commit to plungingChode/stepci that referenced this issue Oct 4, 2023
plungingChode added a commit to plungingChode/stepci that referenced this issue Oct 4, 2023
@mishushakov
Copy link
Member

Have you tried the below:

stepci -e 'A=B`

@sebastianwis
Copy link
Contributor

Hey @plungingChode
Thanks for creating the issue! Would you mind joining our Discord?
https://discord.com/invite/KqJJzJ3BTu

Would love to hear from you!

@plungingChode
Copy link
Contributor Author

Have you tried the below:

stepci -e 'A=B`

Hi! Yes, but my issue is that if an environment variable passed as a CLI argument contains an equals sign (for some reason), anything after the second = is completely ignored. What I'd expect is for

stepci -e 'var=A=B'

to be available to use in the workflow as ${{env.var}}, having the value A=B. Instead, it is just parsed as A. If this is intended, please feel free to close the issue.

@sebastianwis
Copy link
Contributor

Hi @plungingChode
Thank you for your contribution here!
It would be amazing to welcome you to our Discord if you haven't joined it yet:
https://discord.com/invite/KqJJzJ3BTu
This is where we keep users up to date with updates, features and bug resolutions.

mishushakov pushed a commit that referenced this issue Dec 30, 2023
mishushakov pushed a commit that referenced this issue Dec 30, 2023
mishushakov pushed a commit that referenced this issue Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants