Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #151 #152

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fixes #151 #152

merged 1 commit into from
Oct 20, 2023

Conversation

plungingChode
Copy link
Contributor

Environment key-value pairs, where the value contains a = character are now parsed correctly.

@mishushakov
Copy link
Member

You can also achieve the same with:

const val = "x=x=y"
const [head, ...tail] = val.split("=")
console.log(head, tail.join("="))

Would you prefer this approach instead? If not, I will just accept your change as is

@plungingChode
Copy link
Contributor Author

If you find your version more readable, I'll update the PR. It didn't really occur to me, to be honest.

@mishushakov
Copy link
Member

mishushakov commented Oct 20, 2023

I will accept and if I change my mind do the change myself. Thanks a lot for the contribution 🙏

@mishushakov mishushakov merged commit db8b62c into stepci:main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants