build JNI as workspace member #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgo build invocation to do it
jadamcrain
force-pushed
the
feature/jni-build-rs
branch
from
250ba82
to
26a94d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP. Building the JNI library as a workspace member will make it easy for the
rust-crossjobs to build it.The x64 one needs to be part of the cross matrix b/c it's creating libs that depends on a newer GLIBC. The ARM64 job could just be part of the cross matrix as well and simplify the CI.
It will also add the bonus that we'll have JNI artifacts for ARMv6/v7.