This repository has been archived by the owner on Jan 14, 2018. It is now read-only.
request processor listeners loss fix #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @seva-ask, I am having a look into this bug fix. Thanks for submitting it. |
|
Thx for this bug fix. I am not sure, but you might have solved one of the source of very rarely occuring bug on CI server ... Let's see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
It's me again with strange multithreaded bugs :)
I've noticed that sometimes my request listeners are not called and then have found these lines in log:
04-20 04:11:56.448 14869-14928/ru.car2car.droid D/RequestProcessor.java:85﹕ 04:11:56.454 SpiceManagerThread 0 Adding entry for type class ru.car2car.droid.requests.api.methods.user.UserProfileRequest$Response and cacheKey http#3A#2F#2Fcar2car.ru#2Fapi#2Fuser#2Fprofile#2F#3Fsession_id#3D535313aa563d22.57601009#0b4dc5b937dd4d3e02881fb3ff20331b.
04-20 04:11:56.448 14869-14927/ru.car2car.droid D/RequestProcessor.java:85﹕ 04:11:56.455 SpiceManagerThread 0 Adding entry for type class ru.car2car.droid.requests.api.methods.user.UserProfileRequest$Response and cacheKey http#3A#2F#2Fcar2car.ru#2Fapi#2Fuser#2Fprofile#2F#3Fsession_id#3D535313aa563d22.57601009#0b4dc5b937dd4d3e02881fb3ff20331b.
It was strange that same log message was repeated almost at same time.
In code I found that request processor has not synchronized adding requests.
I also have written a test that failes with old version and passes with new.
P.S. You asked me to tell when project using Robospice will be released to market. So it's there: https://play.google.com/store/apps/details?id=ru.stream.droid. I think later I can give links to some more our projects with Robospice.