Skip to content
This repository has been archived by the owner on Jan 14, 2018. It is now read-only.

Remove unbinding before removing listeners refactored #318

Conversation

seva-ask
Copy link
Contributor

Refactoring of #317

@stephanenicolas
Copy link
Owner

Thx. I follow up.

@stephanenicolas
Copy link
Owner

@seva-ask . Would you mind patching the issue on travis (finbugs synchronization inconsistency).

No need to re-open a new PR each time. Just

  • code,
  • push on the same branch as much as you want to trigger the build on travis
  • when it passes, squash your commits
  • push --force on your remote and it will trigger the build one last time with a single commit.

Then tell me to review and merge ;)

@stephanenicolas
Copy link
Owner

Oh, and don't forget to rebase from current master, in case some recent commit changed anything regarding your patch.

@seva-ask
Copy link
Contributor Author

I've done what you asked me.
I fixed real warnings from checkstyle and findbugs that failed the build.
But build is sometimes failed on one of the platforms because of network reasons, you can see it in logs. I don't know how to fix it, maybe somewhere timeout settings exist.
Please review the result.

@stephanenicolas stephanenicolas merged commit e4e9db0 into stephanenicolas:master Jun 12, 2014
@stephanenicolas
Copy link
Owner

Thx for this fix. It was really clear and easy to merge.

@seva-ask
Copy link
Contributor Author

Thank you. I didn't know about squash, it's useful and interesting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants