Skip to content

Commit

Permalink
BUG In Travis, restrict pandas version downloaded
Browse files Browse the repository at this point in the history
Pandas dropped Python 3.4 support with v0.21, and our Python 3.4 tests have recently begun failing when they attempt to install the newest version. Our Travis tests were installing all of the optional packages in a separate line; move those to their own requirements file so that we can control which version is intalled where. See also pandas-dev/pandas#20697 .
  • Loading branch information
Stephen Hoover committed Apr 16, 2018
1 parent 242d2e2 commit 5ce217e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ python:
install:
- pip install --upgrade pip setuptools
- pip install -r dev-requirements.txt
- pip install pandas scikit-learn scipy feather-format
- pip install -r full-testing-requirements.txt
- pip install -e .
env:
global:
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
- Include JSON files with pip distributions (#244)
- Added flush to `civis_to_file` when passed a user-created buffer,
ensuring the buffer contains the entire file when subsequently read.
- Travis tests for Python 3.4 are now restricted to pandas<=0.20, the
last version which supported Python 3.4 (#249)

### Added
- Added a utility function which can robustly split a Redshift schema name
Expand Down
7 changes: 7 additions & 0 deletions full-testing-requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
feather-format
numpy
pandas; python_version >= '3.5'
pandas<0.21; python_version == '3.4'
pandas<=0.23; python_version == '2.7'
scikit-learn
scipy

0 comments on commit 5ce217e

Please sign in to comment.